Skip to content

bpo-38871: Fix lib2to3 to be able to use in edge cases of filter#17780

Merged
vstinner merged 3 commits into
python:masterfrom
corona10:bpo-38871
Jan 7, 2020
Merged

bpo-38871: Fix lib2to3 to be able to use in edge cases of filter#17780
vstinner merged 3 commits into
python:masterfrom
corona10:bpo-38871

Conversation

@corona10

@corona10 corona10 commented Jan 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@corona10
corona10 requested review from benjaminp and vstinner January 1, 2020 09:48
@corona10 corona10 changed the title bpo-38871: Fix lib2to3 to be able to use in edge cases of filter [WIP] bpo-38871: Fix lib2to3 to be able to use in edge cases of filter Jan 1, 2020
@corona10 corona10 changed the title [WIP] bpo-38871: Fix lib2to3 to be able to use in edge cases of filter bpo-38871: Fix lib2to3 to be able to use in edge cases of filter Jan 1, 2020
@pablogsal
pablogsal self-requested a review January 3, 2020 19:16
@pablogsal pablogsal self-assigned this Jan 3, 2020
@vstinner

vstinner commented Jan 6, 2020

Copy link
Copy Markdown
Member

@benjaminp @pablogsal @isidentical: Would you mind to have a look?

pablogsal
pablogsal requested changes Jan 6, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-01-01-18-44-52.bpo-38871.3EEOLg.rst Outdated
@bedevere-bot

bedevere-bot commented Jan 6, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10

corona10 commented Jan 7, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 7, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@bedevere-bot
bedevere-bot requested a review from pablogsal January 7, 2020 02:52
pablogsal
pablogsal reviewed Jan 7, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-01-01-18-44-52.bpo-38871.3EEOLg.rst Outdated
@corona10
corona10 requested a review from pablogsal January 7, 2020 12:22
@vstinner
vstinner merged commit b821173 into python:master Jan 7, 2020
@miss-islington

miss-islington commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2020
@corona10 @miss-islington
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
3ce3a3d 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

bedevere-bot commented Jan 7, 2020

Copy link
Copy Markdown

GH-17899 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2020
@corona10 @miss-islington
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
d6a9419 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@vstinner

vstinner commented Jan 7, 2020

Copy link
Copy Markdown
Member

Thanks @corona10 for updating the NEWS entry. I rewrote the commit message.

@bedevere-bot

bedevere-bot commented Jan 7, 2020

Copy link
Copy Markdown

GH-17900 is a backport of this pull request to the 3.7 branch.

@pablogsal

pablogsal commented Jan 7, 2020

Copy link
Copy Markdown
Member

Thanks for the PR, @corona10 !

miss-islington added a commit that referenced this pull request Jan 7, 2020
@miss-islington @corona10
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
535a3c4 
GH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Jan 7, 2020
@miss-islington @corona10
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
39a5c88 
GH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
(cherry picked from commit b821173)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@corona10 @shihai1991
bpo-38871: Fix lib2to3 for filter-based statements that contain lambda (
1c82b88 
pythonGH-17780)

Correctly parenthesize filter-based statements that contain lambda
expressions in lib2to3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@benjaminp benjaminp Awaiting requested review from benjaminp
@vstinner vstinner Awaiting requested review from vstinner

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @vstinner @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni