Skip to content

[2.7] bpo-27973 - urlretrive fails on second ftp transfer. #17774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orsenthil merged 1 commit into from
Jan 4, 2020
Merged

[2.7] bpo-27973 - urlretrive fails on second ftp transfer. #17774

orsenthil merged 1 commit into from
Jan 4, 2020

Conversation

@orsenthil
Copy link
Member

@orsenthil orsenthil commented Dec 31, 2019 •
edited by bedevere-bot
Loading

Fix the permission denied errors on Windows.

This is a fix for the permission denied error observed on windows buildbots.

Tests result: FAILURE then FAILURE
test test_urllibnet failed -- Traceback (most recent call last):
  File "D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\test\test_urllibnet.py", line 232, in test_multiple_ftp_retrieves
    "multiple times.\n Error message was : %s" % e)
AssertionError: Failed FTP retrieve while accessing ftp url multiple times.
 Error message was : [Errno 13] Permission denied: 'd:\\temp\\tmpiuquqa'
Example failure:

https://buildbot.python.org/all/#/builders/209/builds/4

https://bugs.python.org/issue27973

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Dec 31, 2019
@orsenthil orsenthil changed the title bpo-27973 - urlretrive fails on second ftp transfer. [2.7] bpo-27973 - urlretrive fails on second ftp transfer. Dec 31, 2019
@orsenthil
bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile f…
ae8b457 
…or the

desired behavior under windows platform.

Suggestion by David Bolen
@orsenthil
Copy link
Member Author

orsenthil commented Jan 3, 2020

@benjaminp please review this. This will fix 2.7 windows build bots.

@orsenthil orsenthil merged commit 5bba602 into python:2.7 Jan 4, 2020
@orsenthil orsenthil deleted the issue27973-win-fix branch January 4, 2020 02:14
@bedevere-bot
Copy link

bedevere-bot commented Jan 4, 2020

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

orsenthil added a commit that referenced this pull request Jan 4, 2020
@orsenthil
Revert "bpo-27973 - Use test.support.temp_dir instead of NamedTempora…
2ddf725 
…ryFile for the (#17774)"

This reverts commit 5bba602.
@orsenthil orsenthil mentioned this pull request Jan 4, 2020
Closed
@orsenthil
Copy link
Member Author

orsenthil commented Jan 4, 2020

I am not sure why we are seeing these buildbot failures on 2.7 branch.
All of the failures observed during build step of 2.7

@pablogsal
Copy link
Member

pablogsal commented Jan 4, 2020 •
edited
Loading

@orsenthil Please, Ignore this failure - I was trying to fix something on the server at the same time :(

Apologies for the noise 😢

@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@python python deleted a comment from bedevere-bot Jan 4, 2020
@orsenthil
Copy link
Member Author

orsenthil commented Jan 4, 2020

I am not sure why we are seeing these buildbot failures on 2.7 branch.

I see this was failing even for the previous SHA. Just the notifications are new.

Buildbot failures

@orsenthil
Copy link
Member Author

orsenthil commented Jan 4, 2020

Thanks, @pablogsal

@pablogsal
Copy link
Member

pablogsal commented Jan 4, 2020 •
edited
Loading

I have re-triggered a build of all the 2.7 buildbots that failed (with the correct build steps) si they should be green in some minutes. Apologies again for the noise.

@pablogsal
Copy link
Member

pablogsal commented Jan 4, 2020

@orsenthil By the way, I will announce this soon (still secret 😉 ) but now you can use the "🔨 test-with-buildbots" label to require all buildbots to report to the PR before merging! 🎉

@orsenthil
Copy link
Member Author

orsenthil commented Jan 4, 2020

I will announce this soon (still secret wink ) but now you can use the "hammer test-with-buildbots" label to require all buildbots to report to the PR before merging!

this will be super cool !

Thank you very much for this feature. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp approved these changes

Assignees

No one assigned

Labels

OS-windows skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@orsenthil @bedevere-bot @pablogsal @benjaminp @the-knights-who-say-ni @aeros