bpo-38971: open file in codecs.open() closes if exception raised #17666
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Open issue in the BPO indicated a desire to make the implementation of codecs.open() at parity with io.open(), which implements a try/except to assure file stream gets closed before an exception is raised.
caporta
force-pushed
the
bpo-38971-fix-codecs-open
branch
from
96e88dc to
f6b7759
Compare
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
The fix LGTM, but I have some comments about the test.
- Move spec out of seperate class and into CodecsModuleTest - Pass invalid encoding to force exception rather than mock - Specify that a LookupError is raised specifically
|
@serhiy-storchaka addressed the above comments, should be ready for re-review. thanks |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Thank you. Yet a nitpick to tests.
Prefer positional args to keywords in spec Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
caporta
requested review from
serhiy-storchaka
and removed request for
serhiy-storchaka
|
@serhiy-storchaka would it be possible to get a re-review of this PR? Thanks in advance! |
serhiy-storchaka
added
needs backport to 3.7
type-bug
|
Thanks @caporta for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @caporta for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-18733 is a backport of this pull request to the 3.7 branch. |
…thonGH-17666) Open issue in the BPO indicated a desire to make the implementation of codecs.open() at parity with io.open(), which implements a try/except to assure file stream gets closed before an exception is raised. (cherry picked from commit 2565ede) Co-authored-by: Chris A <christopher.aporta@gmail.com>
…thonGH-17666) Open issue in the BPO indicated a desire to make the implementation of codecs.open() at parity with io.open(), which implements a try/except to assure file stream gets closed before an exception is raised. (cherry picked from commit 2565ede) Co-authored-by: Chris A <christopher.aporta@gmail.com>
|
GH-18734 is a backport of this pull request to the 3.8 branch. |
…-17666) Open issue in the BPO indicated a desire to make the implementation of codecs.open() at parity with io.open(), which implements a try/except to assure file stream gets closed before an exception is raised. (cherry picked from commit 2565ede) Co-authored-by: Chris A <christopher.aporta@gmail.com>
…-17666) Open issue in the BPO indicated a desire to make the implementation of codecs.open() at parity with io.open(), which implements a try/except to assure file stream gets closed before an exception is raised. (cherry picked from commit 2565ede) Co-authored-by: Chris A <christopher.aporta@gmail.com>
5 participants
https://bugs.python.org/issue38971
Open issue in the BPO indicated a desire to make the implementation of
codecs.open() at parity with io.open(), which implements a try/except to
assure file stream gets closed before an exception is raised.
https://bugs.python.org/issue38971