bpo-39091: Fix segfault when Exception constructor returns non-exception for gen.throw by coolreader18 · Pull Request #17658 · python/cpython

coolreader18 · 2019-12-19T05:08:20Z

I added a type check in _PyErr_CreateException as @serhiy-storchaka suggested.

I'm not sure if I should replace the check in do_raise in ceval.c with a call to _PyErr_CreateException somehow, as it's effectively the same functionality?

https://bugs.python.org/issue39091

the-knights-who-say-ni · 2019-12-19T05:08:23Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@coolreader18

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

serhiy-storchaka · 2019-12-21T19:12:38Z

do_raise has a complex code. Unless it contains similar bug I suggest to left refactoring to other issue.

coolreader18 · 2020-01-15T01:09:01Z

Any updates on this?

corona10

@serhiy-storchaka @vstinner
This PR is waiting for review for a long time.
Can you please take a look?

codecov · 2020-02-16T23:26:11Z

Codecov Report

Merging #17658 into master will increase coverage by 1.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #17658       +/-   ##
===========================================
+ Coverage   82.11%   83.20%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589364   414752   -174612     
  Branches    44457    44457               
===========================================
- Hits       483963   345084   -138879     
+ Misses      95748    60021    -35727     
+ Partials     9653     9647        -6

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 434 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33bdbb...95254b4. Read the comment docs.

bl-ue · 2021-06-17T13:28:13Z

ping @serhiy-storchaka @vstinner this PR needs to be merged.

bedevere-bot · 2021-08-03T02:17:20Z

@benjaminp: Please replace # with GH- in the commit message next time. Thanks!

miss-islington · 2021-08-03T02:17:21Z

Thanks @coolreader18 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.8, 3.9.
🐍🍒⛏🤖

bedevere-bot · 2021-08-03T02:17:31Z

GH-27572 is a backport of this pull request to the 3.10 branch.

bedevere-bot · 2021-08-03T02:17:37Z

GH-27573 is a backport of this pull request to the 3.9 branch.

miss-islington · 2021-08-03T02:17:37Z

Sorry, @coolreader18 and @benjaminp, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 83ca46b7784b7357d82ec47b33295e09ed7380cb 3.8

…-exception for gen.throw. (pythonGH-17658) Co-authored-by: Benjamin Peterson <benjamin@python.org> (cherry picked from commit 83ca46b) Co-authored-by: Noah <33094578+coolreader18@users.noreply.github.com>

…ion for gen.throw. (GH-17658) (GH-27572) Co-authored-by: Benjamin Peterson <benjamin@python.org> (cherry picked from commit 83ca46b) Co-authored-by: Noah <33094578+coolreader18@users.noreply.github.com>

…ion for gen.throw. (GH-17658) (GH-27573) Co-authored-by: Benjamin Peterson <benjamin@python.org> (cherry picked from commit 83ca46b) Co-authored-by: Noah <33094578+coolreader18@users.noreply.github.com>

vstinner · 2021-08-06T11:24:24Z

Thanks for the fix!

nocturn9x · 2021-08-25T06:15:52Z

Took 2 years but it's finally getting fixed! 😂

vstinner · 2021-08-30T13:23:14Z

Better late than never.

the-knights-who-say-ni added the CLA not signed label Dec 19, 2019

bedevere-bot added the awaiting review label Dec 19, 2019

coolreader18 changed the title ~~bpo-39091: Fix segfault when Exception constructor returns non-exception for gen.throw (and probably some other places)~~ bpo-39091: Fix segfault when Exception constructor returns non-exception for gen.throw Dec 19, 2019

eric-wieser reviewed Dec 19, 2019

View reviewed changes

Comment thread Lib/test/test_generators.py Outdated

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Dec 19, 2019

coolreader18 force-pushed the gen-throw-bpo-39091 branch 2 times, most recently from ad65177 to 08e42d6 Compare December 19, 2019 23:25

eric-wieser reviewed Dec 20, 2019

View reviewed changes

Comment thread Lib/test/test_generators.py Outdated

serhiy-storchaka reviewed Dec 21, 2019

View reviewed changes

Comment thread Python/errors.c Outdated

Comment thread Python/errors.c Outdated

Comment thread Python/errors.c Outdated

serhiy-storchaka reviewed Dec 21, 2019

View reviewed changes

Comment thread Misc/NEWS.d/next/Core and Builtins/2019-12-19-23-02-54.bpo-39091.9eCROl.rst Outdated

coolreader18 added 2 commits December 22, 2019 22:20

bpo-39091: Add BaseException type check in _PyErr_CreateException

2f80cdc

Add test for gen.throw TypeError

5ab6667

coolreader18 force-pushed the gen-throw-bpo-39091 branch from 3cb4685 to a2a7e43 Compare December 23, 2019 04:21

ZackerySpytz reviewed Dec 23, 2019

View reviewed changes

Comment thread Misc/NEWS.d/next/Core and Builtins/2019-12-21-14-18-32.bpo-39091.dOexgQ.rst Outdated

Comment thread Misc/ACKS Outdated

coolreader18 force-pushed the gen-throw-bpo-39091 branch from a2a7e43 to bfa9b85 Compare December 23, 2019 14:44

corona10 requested a review from serhiy-storchaka January 24, 2020 17:33

corona10 reviewed Jan 24, 2020

View reviewed changes

Comment thread Misc/NEWS.d/next/Core and Builtins/2019-12-21-14-18-32.bpo-39091.dOexgQ.rst Outdated

coolreader18 added 4 commits January 24, 2020 18:44

Add check that generator is exhausted after throwing

2f91b9f

Add check for TypeError inside of the generator

7f4a5da

Fix exc leak; format with tp_name

61f8feb

Add name to Misc/ACKS and add blurb

335a292

coolreader18 force-pushed the gen-throw-bpo-39091 branch from bfa9b85 to 335a292 Compare January 25, 2020 00:46

corona10 reviewed Feb 3, 2020

View reviewed changes

corona10 requested a review from vstinner February 3, 2020 14:02

Merge branch 'master' into gen-throw-bpo-39091

95254b4

tweak news

4e11587

benjaminp added needs backport to 3.8 needs backport to 3.10 only security fixes labels Aug 3, 2021

benjaminp merged commit 83ca46b into python:main Aug 3, 2021

bedevere-bot removed the awaiting review label Aug 3, 2021

bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.9 labels Aug 3, 2021

miss-islington assigned benjaminp Aug 3, 2021

benjaminp removed the needs backport to 3.8 label Aug 3, 2021

coolreader18 deleted the gen-throw-bpo-39091 branch August 31, 2021 02:03

Uh oh!

Uh oh!

Conversation

coolreader18 commented Dec 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Dec 19, 2019

CLA Missing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka commented Dec 21, 2019

Uh oh!

Uh oh!

Uh oh!

coolreader18 commented Jan 15, 2020

Uh oh!

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 16, 2020

Codecov Report

Uh oh!

bl-ue commented Jun 17, 2021

Uh oh!

bedevere-bot commented Aug 3, 2021

Uh oh!

miss-islington commented Aug 3, 2021

Uh oh!

bedevere-bot commented Aug 3, 2021

Uh oh!

bedevere-bot commented Aug 3, 2021

Uh oh!

miss-islington commented Aug 3, 2021

Uh oh!

vstinner commented Aug 6, 2021

Uh oh!

nocturn9x commented Aug 25, 2021

Uh oh!

vstinner commented Aug 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

coolreader18 commented Dec 19, 2019 •

edited

Loading