Actually, this seems that does not only affect starred expressions. For example:

>>> val = "f(a,b,c)"
>>> val[ast.parse(val).body[0].value.args[2].end_col_offset]
')'
>>> val[ast.parse(val).body[0].value.args[0].end_col_offset]
','
>>> val[ast.parse(val).body[0].value.args[1].end_col_offset]
','
>>> val[ast.parse(val).body[0].value.args[2].end_col_offset]
')'

that seems odd.

Possibly @ilevkivskyi would also be interested in hearing about this?

Nevermind, I imagine that is so you can do expression[col_offset:end_col_offset].

Actually, this seems that does not only affect starred expressions.

That's actually ok, because end_col_offset is always where the token ends + 1. In your examples col_offset of a is 2 and end_col_offset is 3, which is the intended behavior.

That's actually ok, because end_col_offset is always where the token ends + 1. In your examples col_offset of a is 2 and end_col_offset is 3, which is the intended behavior.

Yup. Also the fix is consistent with extracting the values via expression[col_offset:end_col_offset]

This doesn't need backport to 3.7 as this is a new feature in 3.8

@ilevkivskyi A similar change I made in #17582 was considered a bugfix and was backported to 3.7

@lysnikolaou In #17582 what changed was the col_offset that is accessible by Python AST objects in 3.7, but end_col_offset and end_lineno was introduced in 3.8.

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

Sorry @lysnikolaou and @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 50d4f12958bf806a4e1a1021d70cfd5d448c5cba 3.8

GH-17649 is a backport of this pull request to the 3.8 branch.