Skip to content

Improves test_underpth_nosite_file to reveal why it fails. - #1763

Merged
zooba merged 8 commits into
python:masterfrom
zooba:fix-site-test
May 23, 2017
Merged

zooba merged 8 commits into
python:masterfrom
zooba:fix-site-test

Conversation

@zooba

@zooba zooba commented May 23, 2017

Copy link
Copy Markdown
Member

No description provided.

@mention-bot

Copy link
Copy Markdown

@zooba, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @tiran and @ezio-melotti to be potential reviewers.

@zooba
zooba requested a review from zware May 23, 2017 17:01
@zooba zooba added the trivial label May 23, 2017
@zooba
zooba requested a review from ericsnowcurrently May 23, 2017 21:11

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, LGTM.

Comment thread Python/pylifecycle.c
Py_FatalError("Py_Initialize: can't initialize sys dict");
Py_INCREF(interp->sysdict);

PySys_SetPath(Py_GetPath());

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment here about how Py_GetPath() must be called before the flags get set.

@zooba
zooba merged commit 9b33bf5 into python:master May 23, 2017
@zooba
zooba deleted the fix-site-test branch May 23, 2017 23:25
@serhiy-storchaka

Copy link
Copy Markdown
Member

assert_() is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants