bpo-39006: Fix asyncio when the ssl module is missing#17524
Conversation
Fix asyncio when the ssl module is missing: only check for ssl.SSLSocket instance if the ssl module is available.
|
Thanks, @vstinner |
|
"I've missed that we run tests without ssl module also. I (wrongly) thought we dropped this configuration from the supported matrix at some time." See https://bugs.python.org/issue39006 : it looks like a bug on the buildbot. But I chose to write a fix since the code already handles ImportError on "import ssl". If you consider that ssl is requires, test_asyncio must be skipped if ssl is missing and code handling ImportError should be removed. IMHO supporting missing ssl doesn't require too much maintenance and so can be kept ;-) |
|
@vstinner you are right. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Fix asyncio when the ssl module is missing: only check for ssl.SSLSocket instance if the ssl module is available. (cherry picked from commit 82b4950) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-17527 is a backport of this pull request to the 3.8 branch. |
|
GH-17528 is a backport of this pull request to the 3.7 branch. |
Fix asyncio when the ssl module is missing: only check for ssl.SSLSocket instance if the ssl module is available. (cherry picked from commit 82b4950) Co-authored-by: Victor Stinner <vstinner@python.org>
Fix asyncio when the ssl module is missing: only check for ssl.SSLSocket instance if the ssl module is available.
5 participants
Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.
https://bugs.python.org/issue39006