bpo-38979: fix ContextVar "__class_getitem__" method#17497

Merged

miss-islington merged 7 commits into

python:masterfrom

amiremohamadi:contextvar-getitem

Dec 8, 2019

amiremohamadi commented Dec 7, 2019 •

edited by miss-islington

Loading

Contributor

now contextvars.ContextVar "class_getitem" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov

amiremohamadi added 3 commits

December 7, 2019 15:47


          bpo-38979: return class from __class_getitem__ to simplify subclassing

5364ad5


          add ContextVar.__class_getitem__ test

50b93ae


          add ContextVar.__class_getitem__ NEWS

26ab478

amiremohamadi requested a review from 1st1 as a code owner

December 7, 2019 13:10

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label

isidentical reviewed

View reviewed changes

Misc/NEWS.d/next/Library/2019-12-07-16-32-42.bpo-38979.q0sIHy.rst Outdated

		@@ -0,0 +1,3 @@
		return class from __class_getitem__ to simplify subclassing. E.g. `clss =
		contextvars.ContextVar[str]` returned `None` instead of `<class

isidentical Dec 7, 2019

Member

IMHO there is no need for examples for this fix

isidentical commented Dec 7, 2019

Member

cpython/Lib/test/test_context.py

Lines 41 to 42 in 26ab478

    
           def test_context_var_new_2(self): 
        
               self.assertIsNone(contextvars.ContextVar[int])

You need to remove this test

isidentical reviewed

View reviewed changes

Misc/NEWS.d/next/Library/2019-12-07-16-32-42.bpo-38979.q0sIHy.rst Outdated

		@@ -0,0 +1,3 @@
		return class from __class_getitem__ to simplify subclassing. E.g. `clss =

isidentical Dec 7, 2019

Member

You might want to use double backtick for __class_getitem__

asvetlov Dec 7, 2019

Contributor

I agree with both @isidentical comments. @amiremohamadi please address them.
Otherwise, the PR looks awesome.

asvetlov requested changes

View reviewed changes

Misc/NEWS.d/next/Library/2019-12-07-16-32-42.bpo-38979.q0sIHy.rst Outdated

		@@ -0,0 +1,3 @@
		return class from __class_getitem__ to simplify subclassing. E.g. `clss =

asvetlov Dec 7, 2019

Contributor

I agree with both @isidentical comments. @amiremohamadi please address them.
Otherwise, the PR looks awesome.

bedevere-bot commented Dec 7, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added awaiting changes and removed awaiting review labels

asvetlov added needs backport to 3.7 labels

asvetlov commented Dec 7, 2019 •

edited

Loading

Contributor

Since __class_getitem__ was here starting from Python 3.7 I think that the backport of the fix makes sense.

It cannot break any code.

amiremohamadi added 2 commits

December 7, 2019 20:10


          revert to previous commit

53fe505


          remove example

amiremohamadi commented Dec 7, 2019

Contributor Author

@asvetlov, @isidentical thanks for your help! :)
I have made the requested changes; please review again

bedevere-bot added awaiting change review and removed awaiting changes labels

bedevere-bot commented Dec 7, 2019

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

bedevere-bot requested a review from asvetlov

December 7, 2019 16:44


          remove test_context_var_new_2

d27d71c

isidentical reviewed

View reviewed changes

Lib/test/test_context.py

isidentical approved these changes

View reviewed changes


          Update 2019-12-07-16-32-42.bpo-38979.q0sIHy.rst

938b77c

asvetlov approved these changes

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels

asvetlov added the 🤖 automerge label

miss-islington commented Dec 8, 2019

Contributor

@amiremohamadi: Status check is done, and it's a success ✅ .

miss-islington merged commit 28c9163 into python:master

miss-islington commented Dec 8, 2019

Contributor

Thanks @amiremohamadi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)

ae7ba6f

now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <31338382+amiremohamadi@users.noreply.github.com>

bedevere-bot removed the needs backport to 3.8 label

bedevere-bot commented Dec 8, 2019

GH-17505 is a backport of this pull request to the 3.8 branch.

bedevere-bot commented Dec 8, 2019

GH-17506 is a backport of this pull request to the 3.7 branch.

bedevere-bot removed the needs backport to 3.7 label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)

2a12f5f

now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <31338382+amiremohamadi@users.noreply.github.com>

miss-islington added a commit that referenced this pull request


          bpo-38979: fix ContextVar "__class_getitem__" method (GH-17497)

9baa870

now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <31338382+amiremohamadi@users.noreply.github.com>

asvetlov added the needs backport to 3.8 label

miss-islington commented Dec 8, 2019

Contributor

Thanks @amiremohamadi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot commented Dec 8, 2019

GH-17507 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)

8bc865e

now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <31338382+amiremohamadi@users.noreply.github.com>

bedevere-bot removed the needs backport to 3.8 label

miss-islington added a commit that referenced this pull request


          bpo-38979: fix ContextVar "__class_getitem__" method (GH-17497)

960fca1

now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None.

https://bugs.python.org/issue38979

Automerge-Triggered-By: @asvetlov
(cherry picked from commit 28c9163)

Co-authored-by: AMIR <31338382+amiremohamadi@users.noreply.github.com>

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request


          bpo-38979: fix ContextVar "__class_getitem__" method (pythonGH-17497)

ab3d109

now contextvars.ContextVar "__class_getitem__" method returns ContextVar class, not None. 


https://bugs.python.org/issue38979



Automerge-Triggered-By: @asvetlov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet