Skip to content

bpo-37465: Parsing: all of s/y/z take a Py_ssize_t #17478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iustin wants to merge 1 commit into from
Closed

bpo-37465: Parsing: all of s/y/z take a Py_ssize_t #17478

iustin wants to merge 1 commit into from

Conversation

@iustin
Copy link

@iustin iustin commented Dec 5, 2019 •
edited by bedevere-bot
Loading

Currently the documentation for z#/y# says they take an int, which is not true with PY_SSIZE_T_CLEAN, as I learned from a segfault :)

https://bugs.python.org/issue37465

@iustin
Parsing: all of s/y/z take a Py_ssize_t
5d61c58 
Currently the documentation for z#/y# says they take an int, which is
not true with `PY_SSIZE_T_CLEAN`, as I learned from a segfault :)
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 5, 2019
@serhiy-storchaka serhiy-storchaka changed the title Parsing: all of s/y/z take a Py_ssize_t bpo-37465: Parsing: all of s/y/z take a Py_ssize_t Jan 25, 2020
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 25, 2020

Thank you for your contribution @iustin. Could you please fix also the documentation for Py_BuildValue?

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 25, 2020

And the PR should be against master. Please rebase.

@iustin
Copy link
Author

iustin commented Jan 25, 2020

Will do, give me a few days.

@methane
Copy link
Member

methane commented Apr 23, 2020

Fixed via GH-18663.

@methane methane closed this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iustin @serhiy-storchaka @methane @the-knights-who-say-ni @bedevere-bot