Skip to content

bpo-38270: Fix indentation of test_hmac assertions#17446

Merged
miss-islington merged 1 commit into
python:masterfrom
stratakis:hmac_indent
Dec 3, 2019
Merged

bpo-38270: Fix indentation of test_hmac assertions#17446
miss-islington merged 1 commit into
python:masterfrom
stratakis:hmac_indent

Conversation

@stratakis

@stratakis stratakis commented Dec 3, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Since c64a1a6 two assertions were indented and thus ignored when running test_hmac.

This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.

https://bugs.python.org/issue38270

Automerge-Triggered-By: @tiran

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Dec 3, 2019
@stratakis

stratakis commented Dec 3, 2019

Copy link
Copy Markdown
Contributor Author

cc @tiran

@stratakis stratakis changed the title bpo-38270: Fix indentation on test_hmac assertions bpo-38270: Fix indentation of test_hmac assertions Dec 3, 2019
@miss-islington miss-islington merged commit 8943318 into python:master Dec 3, 2019
@miss-islington

miss-islington commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington

miss-islington commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

Thanks @stratakis for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 3, 2019
@stratakis @miss-islington
bpo-38270: Fix indentation of test_hmac assertions (pythonGH-17446)
ebef3a5 
Since python@c64a1a6 two assertions were indented and thus ignored when running test_hmac.

This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.

https://bugs.python.org/issue38270
(cherry picked from commit 8943318)

Co-authored-by: stratakis <cstratak@redhat.com>
@bedevere-bot

bedevere-bot commented Dec 3, 2019

Copy link
Copy Markdown

GH-17450 is a backport of this pull request to the 3.8 branch.

stratakis added a commit to stratakis/cpython that referenced this pull request Dec 3, 2019
@stratakis
bpo-38270: Fix indentation of test_hmac assertions (pythonGH-17446)
19a40f7 
Since python@c64a1a6 two assertions were indented and thus ignored when running test_hmac.

This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.


https://bugs.python.org/issue38270
@bedevere-bot

bedevere-bot commented Dec 3, 2019

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit 8943318.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/81/builds/8) and take a look at the build logs.
  4. Check if the failure is related to this commit (8943318) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/81/builds/8

Failed tests:

  • test_regrtest

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

387 tests OK.

10 slowest tests:

  • test_multiprocessing_spawn: 2 min 47 sec
  • test_unparse: 1 min 48 sec
  • test_tokenize: 1 min 47 sec
  • test_concurrent_futures: 1 min 33 sec
  • test_capi: 1 min 13 sec
  • test_lib2to3: 1 min 13 sec
  • test_unicodedata: 1 min 10 sec
  • test_io: 1 min 6 sec
  • test_asyncio: 1 min 3 sec
  • test_mmap: 1 min 2 sec

33 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_tix test_tk test_ttk_guionly
test_wait3 test_wait4 test_xxtestfuzz test_zipfile64

1 re-run test:
test_regrtest

Total duration: 18 min 3 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 380, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_7324\\test_python_worker_7004'


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 1093, in temp_dir
    yield path
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 1145, in temp_cwd
    yield cwd_dir
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 634, in main
    self._main(tests, kwargs)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 707, in _main
    sys.exit(0)
SystemExit: 0


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\__main__.py", line 2, in <module>
    main()
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 712, in main
    Regrtest().main(tests=tests, **kwargs)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 634, in main
    self._main(tests, kwargs)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\contextlib.py", line 131, in __exit__
    self.gen.throw(type, value, traceback)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 1145, in temp_cwd

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@stratakis
bpo-38270: Fix indentation of test_hmac assertions (pythonGH-17446)
ef16116 
Since python@c64a1a6 two assertions were indented and thus ignored when running test_hmac.

This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.


https://bugs.python.org/issue38270
miss-islington added a commit that referenced this pull request Dec 5, 2019
@miss-islington
[3.8] bpo-38270: Fix indentation of test_hmac assertions (GH-17446) (G…
cfdaf92 
…H-17450)

Since c64a1a6 two assertions were indented and thus ignored when running test_hmac.

This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.


https://bugs.python.org/issue38270
(cherry picked from commit 8943318)


Co-authored-by: stratakis <cstratak@redhat.com>


https://bugs.python.org/issue38270



Automerge-Triggered-By: @tiran
stratakis pushed a commit to stratakis/cpython that referenced this pull request Dec 12, 2019
@miss-islington @stratakis
[3.8] bpo-38270: Fix indentation of test_hmac assertions (pythonGH-17446
f01bee1 
) (pythonGH-17450)

Since python@c64a1a6 two assertions were indented and thus ignored when running test_hmac.

This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.


https://bugs.python.org/issue38270
(cherry picked from commit 8943318)


Co-authored-by: stratakis <cstratak@redhat.com>


https://bugs.python.org/issue38270



Automerge-Triggered-By: @tiran
@stratakis stratakis deleted the hmac_indent branch January 3, 2020 21:28
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@stratakis @shihai1991
bpo-38270: Fix indentation of test_hmac assertions (pythonGH-17446)
4d62435 
Since python@c64a1a6 two assertions were indented and thus ignored when running test_hmac.

This PR fixes it. As the change is quite trivial I didn't add a NEWS entry.


https://bugs.python.org/issue38270
@tiran tiran mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stratakis @miss-islington @bedevere-bot @tiran @encukou @the-knights-who-say-ni