Skip to content

bpo-36470: Allow dataclasses.replace() to work InitVar with default values#17441

Closed
PCManticore wants to merge 1 commit into
python:masterfrom
PCManticore:bpo-36470-replace-for-default-init-vars
Closed

bpo-36470: Allow dataclasses.replace() to work InitVar with default values#17441
PCManticore wants to merge 1 commit into
python:masterfrom
PCManticore:bpo-36470-replace-for-default-init-vars

Conversation

@PCManticore

@PCManticore PCManticore commented Dec 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

If a dataclass contain an InitVar, that InitVar must be specified in the call to replace(), unless it has a default value, in which case replace() should not raise a ValueError if the value was not specified in the call to replace().

https://bugs.python.org/issue36470

ericvsmith
ericvsmith requested changes Dec 8, 2019
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2019-12-02-21-03-41.bpo-36470.Gy9Sff.rst Outdated
Comment thread Lib/test/test_dataclasses.py Outdated
Comment thread Lib/test/test_dataclasses.py Outdated
@bedevere-bot

bedevere-bot commented Dec 8, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@PCManticore
bpo-36470: Allow dataclasses.replace() to work InitVar with default v…
2dca685 
…alues

If a dataclass contain an InitVar, that InitVar must be specified in the
call to replace(), unless it has a default value, in which case replace()
should not raise a `ValueError` if the value was not specified in the call
to replace(). Patch by Claudiu Popa.
@PCManticore
PCManticore force-pushed the bpo-36470-replace-for-default-init-vars branch from 8dc7351 to 2dca685 Compare December 8, 2019 12:36
@PCManticore

PCManticore commented Dec 8, 2019

Copy link
Copy Markdown
Contributor Author

Hi @ericvsmith

Thank you for the review! Sorry about that print, should have double checked before sending it in.

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Dec 8, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@csabella
csabella requested review from ericvsmith and removed request for ericvsmith January 25, 2020 20:04
@anthrotype

anthrotype commented Jan 29, 2021

Copy link
Copy Markdown

I see https://bugs.python.org/issue36470 is still open. Why was this PR closed without a merge?
The issue makes using dataclasses.replace impossible with InitVars that have default values (which I believe is quite common).
Please consider reopening this, thank you

@anthrotype anthrotype mentioned this pull request Jan 29, 2021
Open
@ericvsmith

ericvsmith commented Jan 29, 2021

Copy link
Copy Markdown
Member

I don't know why it was closed. I'll try and take a look at the bpo.

@cadiv

cadiv commented Mar 31, 2021

Copy link
Copy Markdown

any news on this? I just hit this issue myself and wound up here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees

No one assigned

Labels

awaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PCManticore @bedevere-bot @anthrotype @ericvsmith @cadiv @the-knights-who-say-ni