Skip to content

bpo-37883 - Added a new method doc to threading.Lock().locked()#17427

Merged
taleinat merged 1 commit into
python:masterfrom
idomic:DocFix
Dec 1, 2019
Merged

bpo-37883 - Added a new method doc to threading.Lock().locked()#17427
taleinat merged 1 commit into
python:masterfrom
idomic:DocFix

Conversation

@idomic

@idomic idomic commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

@idomic

idomic commented Dec 1, 2019

Copy link
Copy Markdown
Contributor Author

Adding @taleinat, I'm also closing the old PR.

@idomic

idomic commented Dec 1, 2019

Copy link
Copy Markdown
Contributor Author

How can I add the skip news label? do I have permissions for that?

@taleinat

taleinat commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

How can I add the skip news label? do I have permissions for that?

@idomic, no, one needs special permissions in order to change labels.

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @idomic for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-17428 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-17429 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-17430 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2019
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
miss-islington added a commit that referenced this pull request Dec 1, 2019
(cherry picked from commit fdafa1d)

Co-authored-by: idomic <michael.ido@gmail.com>
@taleinat

taleinat commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

Congratulations on your first contribution to CPython, @idomic! 🍾

@idomic

idomic commented Dec 1, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for the quick response and help along the way 💯 :)

@idomic
idomic deleted the DocFix branch December 1, 2019 20:37
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants