Skip to content

bpo-38918: Add __module__ entry for function & method type in inspect docs table#17408

Merged
miss-islington merged 1 commit into
python:masterfrom
parthsharma2:bpo-38918
Dec 20, 2019
Merged

bpo-38918: Add __module__ entry for function & method type in inspect docs table#17408
miss-islington merged 1 commit into
python:masterfrom
parthsharma2:bpo-38918

Conversation

@parthsharma2

@parthsharma2 parthsharma2 commented Nov 27, 2019

Copy link
Copy Markdown
Contributor

Adds__module__ entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918

Automerge-Triggered-By: @ericsnowcurrently

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@parthsharma2

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@parthsharma2

Copy link
Copy Markdown
Contributor Author

Should I make a news entry in Misc/NEWS.d/next?

@ericsnowcurrently
ericsnowcurrently self-requested a review December 13, 2019 21:44

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just make sure to add a NEWS entry. See: https://devguide.python.org/committing/#what-s-new-and-news-entries

@parthsharma2

Copy link
Copy Markdown
Contributor Author

@ericsnowcurrently added a NEWS entry

@ericsnowcurrently

Copy link
Copy Markdown
Member

close-and-reopen to force checks to re-run.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @parthsharma2 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @parthsharma2 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-17675 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2019
… docs table (pythonGH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-17676 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2019
… docs table (pythonGH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 20, 2019
… docs table (GH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 20, 2019
… docs table (GH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.

https://bugs.python.org/issue38918
(cherry picked from commit f522a6d)

Co-authored-by: Parth Sharma <parthsharma2@users.noreply.github.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
… docs table (pythonGH-17408)

Adds` __module__ ` entries for function & method types in inspect docs table.





https://bugs.python.org/issue38918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants