Skip to content

bpo-3530: Use fix_missing_locations when node transformer adds nodes#17172

Merged
pablogsal merged 6 commits into
python:masterfrom
isidentical:bpo-3530
Jan 12, 2020
Merged

bpo-3530: Use fix_missing_locations when node transformer adds nodes#17172
pablogsal merged 6 commits into
python:masterfrom
isidentical:bpo-3530

Conversation

@isidentical

@isidentical isidentical commented Nov 15, 2019

Copy link
Copy Markdown
Member

Remove misleading (inadequate) suggestion from example.

https://bugs.python.org/issue3530

Automerge-Triggered-By: @pablogsal

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 15, 2019
@terryjreedy terryjreedy changed the title bpo-3530: advice fix_missing_locations usage on new node introduction bpo-3530: use fix_missing_locations when adding nodes Nov 17, 2019
@terryjreedy terryjreedy changed the title bpo-3530: use fix_missing_locations when adding nodes bpo-3530: Use fix_missing_locations when node transformer adds nodes Nov 17, 2019
@terryjreedy

Copy link
Copy Markdown
Member

@isidentical Please add news item with blurb or blurb-it(sp?). Suggestion:
In ast doc, fix misleading NodeTransformer example and add fix_missing_locations advice.

Comment thread Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated
Comment thread Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated
Comment thread Doc/library/ast.rst Outdated
Comment thread Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated
Comment thread Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
Comment thread Doc/library/ast.rst

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work! 🎉

Comment thread Misc/NEWS.d/next/Documentation/2019-11-17-11-53-10.bpo-3530.8zFUMc.rst Outdated
…FUMc.rst

Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal
pablogsal merged commit 6680f4a into python:master Jan 12, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-17972 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-17973 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 12, 2020
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 12, 2020
…n the AST docs (GH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 6680f4a)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
…n the AST docs (pythonGH-17172)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants