bpo-38558: Mention := in conditions tutorial.
#16919
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeros
reviewed
Oct 24, 2019
Contributor
aeros
left a comment
aeros
left a comment
There was a problem hiding this comment.
Good catch @ammaraskar, this section of the tutorial should definitely be updated to mention the walrus operator for 3.8 and 3.9.
aeros
approved these changes
Oct 25, 2019
zware
approved these changes
Oct 25, 2019
Contributor
|
Thanks @ammaraskar for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Member
|
Thanks for the patch! |
|
GH-16926 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 25, 2019
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mention about assignments is now stale with the introduction of the assignment expression operator. Adjust the wording to mention that
:=must be used explicitly, the rest of the paragraph explaining motivation still applies.https://bugs.python.org/issue38558