Skip to content

gh-57187: Add support for extended attributes on FreeBSD #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
worr wants to merge 1 commit into from
+482 −71
Closed

gh-57187: Add support for extended attributes on FreeBSD #1690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2781,18 +2781,21 @@ def supports_extended_attributes():

@unittest.skipUnless(supports_extended_attributes(),
"no non-broken extended attribute support")
# Kernels < 2.6.39 don't respect setxattr flags.
@support.requires_linux_version(2, 6, 39)
class ExtendedAttributeTests(unittest.TestCase):

def _check_xattrs_str(self, s, getxattr, setxattr, removexattr, listxattr, **kwargs):
fn = support.TESTFN
if sys.platform.startswith("freebsd"):
xattr_errno = errno.ENOATTR
else:
xattr_errno = errno.ENODATA

self.addCleanup(support.unlink, fn)
create_file(fn)

with self.assertRaises(OSError) as cm:
getxattr(fn, s("user.test"), **kwargs)
self.assertEqual(cm.exception.errno, errno.ENODATA)
self.assertEqual(cm.exception.errno, xattr_errno)

init_xattr = listxattr(fn)
self.assertIsInstance(init_xattr, list)
Expand All @@ -2811,7 +2814,7 @@ def _check_xattrs_str(self, s, getxattr, setxattr, removexattr, listxattr, **kwa

with self.assertRaises(OSError) as cm:
setxattr(fn, s("user.test2"), b"bye", os.XATTR_REPLACE, **kwargs)
self.assertEqual(cm.exception.errno, errno.ENODATA)
self.assertEqual(cm.exception.errno, xattr_errno)

setxattr(fn, s("user.test2"), b"foo", os.XATTR_CREATE, **kwargs)
xattr.add("user.test2")
Expand All @@ -2820,7 +2823,7 @@ def _check_xattrs_str(self, s, getxattr, setxattr, removexattr, listxattr, **kwa

with self.assertRaises(OSError) as cm:
getxattr(fn, s("user.test"), **kwargs)
self.assertEqual(cm.exception.errno, errno.ENODATA)
self.assertEqual(cm.exception.errno, xattr_errno)

xattr.remove("user.test")
self.assertEqual(set(listxattr(fn)), xattr)
Expand All @@ -2840,14 +2843,23 @@ def _check_xattrs(self, *args, **kwargs):
self._check_xattrs_str(os.fsencode, *args, **kwargs)
support.unlink(support.TESTFN)

# Kernels < 2.6.39 don't respect setxattr flags.
@support.requires_linux_version(2, 6, 39)
@support.requires_freebsd_version(5)
def test_simple(self):
self._check_xattrs(os.getxattr, os.setxattr, os.removexattr,
os.listxattr)

# Kernels < 2.6.39 don't respect setxattr flags.
@support.requires_linux_version(2, 6, 39)
@support.requires_freebsd_version(5)
def test_lpath(self):
self._check_xattrs(os.getxattr, os.setxattr, os.removexattr,
os.listxattr, follow_symlinks=False)

# Kernels < 2.6.39 don't respect setxattr flags.
@support.requires_linux_version(2, 6, 39)
@support.requires_freebsd_version(5)
def test_fds(self):
def getxattr(path, *args):
with open(path, "rb") as fp:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-03-02-23-38-36.bpo-12978.GmUrw4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add support for extended attributes on FreeBSD
Loading