Skip to content

bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POSIX_C_SOURCE #16733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Oct 12, 2019
Merged

bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POSIX_C_SOURCE #16733

pablogsal merged 1 commit into from
Oct 12, 2019

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 12, 2019 •
edited by miss-islington
Loading

@pablogsal pablogsal changed the title bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POS… bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POSIX_C_SOURCE Oct 12, 2019
@pablogsal pablogsal merged commit 8177404 into python:master Oct 12, 2019
@pablogsal pablogsal deleted the bpo37731 branch October 12, 2019 19:14
@miss-islington
Copy link
Contributor

miss-islington commented Oct 12, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2019
@pablogsal @miss-islington
bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POS…
4f8e4a1 
…IX_C_SOURCE (pythonGH-16733)

(cherry picked from commit 8177404)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 12, 2019

GH-16734 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 12, 2019
@miss-islington @pablogsal
bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POS…
ba44ea6 
…IX_C_SOURCE (GH-16733)

(cherry picked from commit 8177404)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Nov 7, 2019

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 7, 2019

GH-17076 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2019
@pablogsal @miss-islington
bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POS…
f765a5d 
…IX_C_SOURCE (pythonGH-16733)

(cherry picked from commit 8177404)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Nov 7, 2019
@miss-islington @pablogsal
bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POS…
30114c7 
…IX_C_SOURCE (GH-16733)

(cherry picked from commit 8177404)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@pablogsal
bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POS…
c1dcd5f 
…IX_C_SOURCE (pythonGH-16733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @benjaminp @the-knights-who-say-ni