bpo-38431: fix dataclasses.InitVar.__repr__#16702
Merged
Merged
Conversation
Fix repr method of InitVar to work with typing objects.
samuelcolvin
force-pushed
the
InitVar-fix
branch
from
October 10, 2019 16:13
94bf02d to
e045143
Compare
samuelcolvin
force-pushed
the
InitVar-fix
branch
from
October 10, 2019 17:00
3f10b36 to
425edc7
Compare
brandtbucher
added
needs backport to 3.8
type-bug
Member
|
Thanks for your time @samuelcolvin, and welcome to CPython! |
brandtbucher
approved these changes
Oct 10, 2019
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
This looks like a good change to me!
Member
|
CC @ericvsmith |
serhiy-storchaka
approved these changes
Oct 12, 2019
Contributor
|
Thanks @samuelcolvin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 13, 2019
pythonGH-16702) (cherry picked from commit 793cb85) Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
|
GH-16744 is a backport of this pull request to the 3.8 branch. |
Member
|
Congrats on your first CPython contribution @samuelcolvin! 🍾 Looking forward to seeing more from you in the future. |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new version of #16700 based off master.
See original bug pydantic/pydantic#886
https://bugs.python.org/issue38431