Skip to content

bpo-38405: Make nested subclasses of typing.NamedTuple pickleable.#16641

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:typing-namedtuple-nested-pickle
Oct 8, 2019
Merged

bpo-38405: Make nested subclasses of typing.NamedTuple pickleable.#16641
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:typing-namedtuple-nested-pickle

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 8, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Oct 8, 2019
ilevkivskyi
ilevkivskyi approved these changes Oct 8, 2019
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and improving the tests! LGTM.

@serhiy-storchaka
serhiy-storchaka merged commit 13abda4 into python:master Oct 8, 2019
@serhiy-storchaka
serhiy-storchaka deleted the typing-namedtuple-nested-pickle branch October 8, 2019 13:29
@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 13abda41003daf599587991d8291f0dacf6e9519 3.7

@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 13abda41003daf599587991d8291f0dacf6e9519 3.8

@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2019
@serhiy-storchaka @miss-islington
bpo-38405: Make nested subclasses of typing.NamedTuple pickleable. (p…
9cc7af3 
…ythonGH-16641)

(cherry picked from commit 13abda4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Oct 8, 2019

Copy link
Copy Markdown

GH-16655 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 8, 2019
@miss-islington @serhiy-storchaka
bpo-38405: Make nested subclasses of typing.NamedTuple pickleable. (G…
10b475a 
…H-16641)

(cherry picked from commit 13abda4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 9, 2019
@serhiy-storchaka
[3.7] bpo-38405: Make nested subclasses of typing.NamedTuple pickleab…
bb6ae64 
…le. (pythonGH-16641).

(cherry picked from commit 13abda4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Oct 9, 2019

Copy link
Copy Markdown

GH-16674 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Oct 9, 2019
@serhiy-storchaka
[3.7] bpo-38405: Make nested subclasses of typing.NamedTuple pickleab…
87db4d3 
…le. (GH-16641). (GH-16674)

(cherry picked from commit 13abda4)
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@serhiy-storchaka
bpo-38405: Make nested subclasses of typing.NamedTuple pickleable. (p…
29d0211 
…ythonGH-16641)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni