Skip to content

bpo-38348: Extend options of ast tool#16540

Merged
vstinner merged 5 commits into
python:masterfrom
isidentical:bpo-38348
Dec 16, 2019
Merged

bpo-38348: Extend options of ast tool#16540
vstinner merged 5 commits into
python:masterfrom
isidentical:bpo-38348

Conversation

@isidentical

@isidentical isidentical commented Oct 2, 2019

Copy link
Copy Markdown
Member

--type-comments and --indent

https://bugs.python.org/issue38348

@brandtbucher brandtbucher added the type-feature A feature request or enhancement label Oct 2, 2019

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Comment thread Lib/ast.py Outdated
Comment thread Doc/library/ast.rst
Comment thread Doc/library/ast.rst Outdated
@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@isidentical

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

Comment thread Lib/ast.py Outdated
Comment thread Doc/library/ast.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2019-10-02-18-15-28.bpo-38348._-5eq2.rst Outdated

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more minor requests

Comment thread Lib/ast.py Outdated
Comment thread Misc/NEWS.d/next/Library/2019-10-02-18-15-28.bpo-38348._-5eq2.rst Outdated
isidentical and others added 2 commits December 16, 2019 20:32
Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-Authored-By: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
…16540)

Add -i and --indent (indentation level), and --no-type-comments
(type comments) command line options to ast parsing tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants