bpo-38271: encrypt private key test files with AES256#16385
Merged
Conversation
tiran
force-pushed
the
bpo38271-pkey-aes
branch
2 times, most recently
from
328354a to
ab145b2
Compare
encukou
reviewed
Sep 25, 2019
encukou
approved these changes
Sep 25, 2019
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
Aside from that nitpick, this looks legit
The private keys for test_ssl were encrypted with 3DES in traditional PKCS#5 format. 3DES and the digest algorithm of PKCS#5 are blocked by some strict crypto policies. Use PKCS#8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo38271-pkey-aes
branch
from
ab145b2 to
bb8ffc9
Compare
Contributor
|
@tiran: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2019
The private keys for test_ssl were encrypted with 3DES in traditional PKCSGH-5 format. 3DES and the digest algorithm of PKCSGH-5 are blocked by some strict crypto policies. Use PKCSGH-8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38271 Automerge-Triggered-By: @tiran (cherry picked from commit bfd0c96) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-16395 is a backport of this pull request to the 3.8 branch. |
|
GH-16396 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2019
The private keys for test_ssl were encrypted with 3DES in traditional PKCSGH-5 format. 3DES and the digest algorithm of PKCSGH-5 are blocked by some strict crypto policies. Use PKCSGH-8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38271 Automerge-Triggered-By: @tiran (cherry picked from commit bfd0c96) Co-authored-by: Christian Heimes <christian@python.org>
miss-islington
added a commit
that referenced
this pull request
Sep 25, 2019
The private keys for test_ssl were encrypted with 3DES in traditional PKCSGH-5 format. 3DES and the digest algorithm of PKCSGH-5 are blocked by some strict crypto policies. Use PKCSGH-8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38271 Automerge-Triggered-By: @tiran (cherry picked from commit bfd0c96) Co-authored-by: Christian Heimes <christian@python.org>
miss-islington
added a commit
that referenced
this pull request
Sep 25, 2019
The private keys for test_ssl were encrypted with 3DES in traditional PKCSGH-5 format. 3DES and the digest algorithm of PKCSGH-5 are blocked by some strict crypto policies. Use PKCSGH-8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38271 Automerge-Triggered-By: @tiran (cherry picked from commit bfd0c96) Co-authored-by: Christian Heimes <christian@python.org>
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Nov 27, 2019
The private keys for test_ssl were encrypted with 3DES in traditional PKCSGH-5 format. 3DES and the digest algorithm of PKCSGH-5 are blocked by some strict crypto policies. Use PKCSGH-8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38271 Automerge-Triggered-By: @tiran (cherry picked from commit bfd0c96) Co-authored-by: Christian Heimes <christian@python.org>
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
The private keys for test_ssl were encrypted with 3DES in traditional PKCS#5 format. 3DES and the digest algorithm of PKCS#5 are blocked by some strict crypto policies. Use PKCS#8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38271 Automerge-Triggered-By: @tiran
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
May 5, 2020
The private keys for test_ssl were encrypted with 3DES in traditional PKCSGH-5 format. 3DES and the digest algorithm of PKCSGH-5 are blocked by some strict crypto policies. Use PKCSGH-8 format with AES256 encryption instead. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue38271 Automerge-Triggered-By: @tiran (cherry picked from commit bfd0c96) Co-authored-by: Christian Heimes <christian@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private keys for test_ssl were encrypted with 3DES in traditional
PKCS#5 format. 3DES and the digest algorithm of PKCS#5 are blocked by
some strict crypto policies. Use PKCS#8 format with AES256 encryption
instead.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue38271
Automerge-Triggered-By: @tiran