Skip to content

Doc: Use the with statement in the first example of the ftplib doc.#16271

Merged
matrixise merged 1 commit into
python:masterfrom
matrixise:doc_library_ftplib_fix_openfile
Sep 26, 2019
Merged

Doc: Use the with statement in the first example of the ftplib doc.#16271
matrixise merged 1 commit into
python:masterfrom
matrixise:doc_library_ftplib_fix_openfile

Conversation

@matrixise

@matrixise matrixise commented Sep 19, 2019

Copy link
Copy Markdown
Member

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Sep 19, 2019
willingc
willingc approved these changes Sep 25, 2019
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matrixise

matrixise commented Sep 26, 2019

Copy link
Copy Markdown
Member Author

Thank you @willingc

@matrixise matrixise merged commit 5d326ab into python:master Sep 26, 2019
@matrixise matrixise deleted the doc_library_ftplib_fix_openfile branch September 26, 2019 07:01
@miss-islington

miss-islington commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

Thanks @matrixise for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 26, 2019

Copy link
Copy Markdown

GH-16412 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Sep 26, 2019

Copy link
Copy Markdown

GH-16413 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2019
@matrixise @miss-islington
Doc: Use the with statement in the first example of the ftplib doc. (…
2b11b4b 
…pythonGH-16271)

(cherry picked from commit 5d326ab)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
matrixise added a commit that referenced this pull request Sep 26, 2019
@miss-islington @matrixise
Doc: Use the with statement in the first example of the ftplib doc. (…
80bde15 
…GH-16271) (GH-16413)

(cherry picked from commit 5d326ab)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
matrixise added a commit that referenced this pull request Sep 26, 2019
@miss-islington @matrixise
Doc: Use the with statement in the first example of the ftplib doc. (…
b3c35fe 
…GH-16271) (GH-16412)

(cherry picked from commit 5d326ab)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@matrixise
Doc: Use the with statement in the first example of the ftplib doc. (…
2aa898b 
…pythonGH-16271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes

@JulienPalard JulienPalard Awaiting requested review from JulienPalard

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matrixise @miss-islington @bedevere-bot @willingc @the-knights-who-say-ni