[3.8] bpo-37828: Fix default mock_name in unittest.mock.assert_called error (GH-16166)#16229
Merged
Merged
Conversation
…pythonGH-16166) In the format string for assert_called the evaluation order is incorrect and hence for mock's without name, 'None' is printed whereas it should be 'mock' like for other messages. The error message is ("Expected '%s' to have been called." % self._mock_name or 'mock'). (cherry picked from commit 5f5f11f) Co-authored-by: Abraham Toriz Cruz <awonderfulcode@gmail.com>
pablogsal
approved these changes
Sep 17, 2019
Contributor
Author
|
@categulario and @pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@categulario and @pablogsal: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@categulario and @pablogsal: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the format string for assert_called the evaluation order is incorrect and hence for mock's without name, 'None' is printed whereas it should be 'mock' like for other messages. The error message is ("Expected '%s' to have been called." % self._mock_name or 'mock').
(cherry picked from commit 5f5f11f)
Co-authored-by: Abraham Toriz Cruz awonderfulcode@gmail.com
https://bugs.python.org/issue37828