Repository navigation
gh-162125: Preserve parentheses when folding email comments - #162163
Open
Burnside999 wants to merge 1 commit into
Open
Burnside999 wants to merge 1 commit into
Burnside999 wants to merge 1 commit into
Conversation
Keep comment delimiters outside encoded words and stop encoded-word merging at actual comment boundaries. Add reproducible generated round-trip tests for Unicode comments, quoted pairs, display names, and folding limits.
Author
|
This PR currently fixes the comment-parenthesis loss in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the loss of comment parentheses reported in #162125. Folding
Ana (ñ) <a@example.com>could turn the comment into part of the display name. The folded header now retains the parentheses, preserving the address semantics when parsed again.Handle comments at their actual token boundaries, keep delimiters outside encoded words, and prevent encoded-word merging across comments. Add reproducible generated round-trip tests for Unicode comments, quoted pairs, and display names, with fixed regressions for nested comments and folding limits.