Repository navigation
gh-162128: Raise error_proto instead of ValueError on malformed port in ftplib.parse229 - #162132
Open
klnmurthi12345 wants to merge 2 commits into
Open
klnmurthi12345 wants to merge 2 commits into
klnmurthi12345 wants to merge 2 commits into
Conversation
klnmurthi12345
force-pushed
the
fix-ftplib-parse229-error
branch
from
November 17, 2026 02:08
f16292d to
ae3fb81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing a malformed
229 Entering Extended Passive Moderesponse where the port field is non-numeric or empty,ftplib.parse229previously raised an unhandledValueErrorinstead oferror_proto(resp).As documented in the function docstring ("Raises error_proto if it does not contain '(|||port|)'"), malformed server responses should raise
ftplib.error_proto(resp).This PR wraps
int(parts[3])in a try/except block to raiseerror_proto(resp) from Nonewhenparts[3]is non-numeric, adds regression tests totest_ftplib.py, and includes a NEWS entry.