Repository navigation
Conversation
…elled When create_connection() runs with happy_eyeballs_delay and is cancelled after an attempt connects but before staggered_race() returns, the race re-raises CancelledError and drops the connected socket. Record the sockets the attempts connect and close them if the race raises.
cnzakii
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
November 15, 2026 18:50
deadlovelll
reviewed
Nov 15, 2026
Pass a list to _connect_sock() instead of wrapping it, as suggested in review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
loop.create_connection()runs withhappy_eyeballs_delayand is cancelled after an attempt has connected but beforestaggered_race()returns, the race re-raisesCancelledErrorand the connected socket is dropped until the garbage collector closes it.create_connection()now records the sockets the attempts connect and closes them if the race raises.staggered_race()is unchanged and still propagates the cancellation.The new test cancels
create_connection()right after the only attempt has returned its socket; it fails without the fix.