Repository navigation
gh-162034: Quote the utils.sh path in the Apple testbed build phase - #162035
Conversation
…hase The "Process Python libraries" build phase sources utils.sh through an unquoted $PROJECT_DIR. The build fails when the project path contains a space, and a *, ? or [ in the path is glob-expanded, so the phase can source another directory's utils.sh. Quote the path in the four testbed projects.
The build phase example in Doc/using/ios.rst, and the one in the utils.sh header comment, source an unquoted path to build_utils.sh. The helper is named utils.sh. Quote the path and use the right file name.
Documentation build overview
|
|
@fametrano Thanks for the PR, please sign the CLA: #162035 (comment) |
done |
|
Thanks! And please could you sign the CLA again? :) See https://devguide.python.org/getting-started/pull-request-lifecycle/#why-do-i-need-to-sign-the-cla-again which is about backports, but will be triggered here by merging in main. Tip: no need to merge in main unless there's a merge conflict to resolve, or there's been a long time since the last run. |
|
Got it, won't update the branch anymore and/or will sign again |
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for the report and PR!
|
Thanks @fametrano for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @fametrano and @freakboy3742, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
Sorry, @fametrano and @freakboy3742, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-162089 is a backport of this pull request to the 3.15 branch. |
|
GH-162090 is a backport of this pull request to the 3.14 branch. |
The Apple testbed fails to build when its path contains a space, because the "Process Python libraries" build phase sources
utils.shthrough an unquoted$PROJECT_DIR. A*,?or[in the path is glob-expanded as well, so the phase can source another directory'sutils.sh. This quotes that path in the iOS, tvOS, visionOS and watchOS testbed projects, and in the example inDoc/using/ios.rstand theutils.shheader, where it also replaces the nonexistentbuild_utils.shwithutils.sh.With the change, an iOS testbed cloned under a path with a space builds and passes
run -- platformon the iOS 27.2 simulator, and the build phase run withPROJECT_DIR=<dir>/run[x]sources its ownutils.sh. The other three projects take the same one-line change; I had no simulator for them.