Skip to content

bpo-38183: Test_idle ignores user config directory.#16198

Merged
terryjreedy merged 7 commits into
python:masterfrom
terryjreedy:bbtest
Sep 16, 2019
Merged

bpo-38183: Test_idle ignores user config directory.#16198
terryjreedy merged 7 commits into
python:masterfrom
terryjreedy:bbtest

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Sep 16, 2019

Copy link
Copy Markdown
Member

It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.

https://bugs.python.org/issue38183

It no longer tries to create .idlerc or any files within.
Users must run IDLE to discover settings save problems.
@terryjreedy

terryjreedy commented Sep 16, 2019

Copy link
Copy Markdown
Member Author

Writing 'recent-files.lst' instead of "$HOME/.idlerc/recent-files.lst" resulted in a new ENV CHANGED failure -- on linux only.
@vstinner Is there documentation on what changes cause a failure?

New patch should prevent writing that file.

@terryjreedy terryjreedy changed the title bpo-38183: Test-idle skips user config directory. bpo-38183: Test_idle skips user config directory. Sep 16, 2019
@terryjreedy terryjreedy changed the title bpo-38183: Test_idle skips user config directory. bpo-38183: Test_idle ignores user config directory. Sep 16, 2019
@terryjreedy
terryjreedy merged commit 0048afc into python:master Sep 16, 2019
@terryjreedy
terryjreedy deleted the bbtest branch September 16, 2019 23:04
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Sep 17, 2019
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Sep 17, 2019
It no longer tries to create or access .idlerc or any files within.
Users must run IDLE to discover problems with saving settings.
(cherry picked from commit 0048afc)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants