Repository navigation
Conversation
Member
Author
|
CC @maurycy |
pablogsal
changed the title
pablogsal
marked this pull request as ready for review
November 14, 2026 00:59
pablogsal
added
type-refactor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the platform-specific lookup code used by Tachyon. macOS now finds
PyRuntimeandAsyncioDebugthrough dyld's loaded images and reads the Mach-O headers from target memory. If loader updates prevent a stable snapshot, the lookup scans executable memory regions. It uses native thread IDs for CPU state, so the inferred pthread offset and cache are gone. The dyld reader and Mach-O parser retain 32-bit and 64-bit formats. Older dyld replies use process metadata to determine pointer width.Windows now queries each target thread through
NtQueryInformationThread. This removes the system-wide process snapshot and its buffer. The query checks the returned process and thread IDs and closes the handle after each call. Native thread IDs remain unsigned throughout the lookup.Related to #138122 (PEP 799) and #135953 (the original profiler proposal).