Skip to content

gh-161861: preserve http continue timeout after rejected request #161862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonghuaroot wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

gh-161861: preserve http continue timeout after rejected request #161862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/http/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,7 +1268,6 @@ def putrequest(self, method, url, skip_host=False,
"""
if continue_timeout <= 0.0:
raise ValueError("continue_timeout must be greater than 0")
self._continue_timeout = continue_timeout

# if a prior response has been completed, then forget about it.
if self.__response and self.__response.isclosed():
Expand All @@ -1294,6 +1293,7 @@ def putrequest(self, method, url, skip_host=False,
#
if self.__state == _CS_IDLE:
self.__state = _CS_REQ_STARTED
self._continue_timeout = continue_timeout
else:
raise CannotSendRequest(self.__state)

Expand Down
14 changes: 14 additions & 0 deletions Lib/test/test_httplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2587,6 +2587,20 @@ def test_putrequest_continue_timeout(self):
self.assertIn(b'Body content', conn.sock.data)
self.assertEqual(conn.getresponse().code, 200)

def test_failed_putrequest_preserves_continue_timeout(self):
conn = FakeSocketHTTPConnection(
b'HTTP/1.1 100 Continue\r\n'
b'\r\n'
)
conn._select = mock.Mock(wraps=conn.fake_select)
conn.putrequest('PUT', '/', continue_timeout=0.25)
with self.assertRaises(client.CannotSendRequest):
conn.putrequest('GET', '/', continue_timeout=10)
conn.putheader('Expect', '100-continue')
conn.putheader('Content-Length', '12')
conn.endheaders(b'Body content')
conn._select.assert_called_once_with([conn.sock], [], [], 0.25)

def test_invalid_continue_timeout(self):
conn = FakeSocketHTTPConnection(b'')
for timeout in (0, -1):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-11-12-17-53-13.gh-issue-161861.Kf7Qm2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Preserve the active request's ``continue_timeout`` when a second
:meth:`~http.client.HTTPConnection.putrequest` call is rejected.
Loading