Repository navigation
Fix copy-pasted assert messages in test_crossinterp - #161835
Open
andresdelfino wants to merge 1 commit into
Open
andresdelfino wants to merge 1 commit into
andresdelfino wants to merge 1 commit into
Conversation
Both test_module() methods checked type(unittest) but reported type(defs) on failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both
test_module()methods (ShareableTypeTestsandMarshalTests), the assertion forunittestreused the message from the line above it:So if
unittestweren't a module, the failure would report the type ofdefsinstead. This changes the message totype(unittest), matching the two lines before it.Found while auditing test assertions for misused arguments (see #161774).
Test-only change, so this should be fine for
skip issue/skip news. Tested locally on Linux; bothtest_moduletests pass.🤖 Generated with Claude Code