Repository navigation
Fix missing comma in test_time tzname assertion - #161832
Open
andresdelfino wants to merge 1 commit into
Open
andresdelfino wants to merge 1 commit into
andresdelfino wants to merge 1 commit into
Conversation
('AEST' 'EST') is implicit string concatenation rather than a tuple, so
the assertIn() in test_tzset was a substring check against 'AESTEST'.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andresdelfino
requested review from
StanFromIreland and
pganssle
as code owners
November 11, 2026 21:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
test_tzset,('AEST' 'EST')is implicit string concatenation rather than a tuple, soassertIn(time.tzname[0], ('AEST' 'EST'))was a substring check against'AESTEST'and would also accept values such as'ST'or'TES'. Adding the missing comma makes it the intended membership check, matching thetzname[1]check on the next line.Found while auditing test assertions for misused arguments.
Test-only change, so this should be fine for
skip issue/skip news. Tested locally on Linux, where the Victoria timezone givestime.tzname == ('AEST', 'AEDT');test_timepasses.🤖 Generated with Claude Code