Repository navigation
gh-161827: Mark _PyEval_EvalFrameDefault as Py_NO_INLINE - #161829
Merged
Fidget-Spinner merged 1 commit intoNov 11, 2026
Merged
Conversation
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
|
All commit authors signed the Contributor License Agreement. |
Fidget-Spinner
approved these changes
Nov 11, 2026
Fidget-Spinner
added
needs backport to 3.14
Fidget-Spinner
enabled auto-merge (squash)
November 11, 2026 21:48
|
Thanks @ikrommyd for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161833 is a backport of this pull request to the 3.15 branch. |
|
GH-161834 is a backport of this pull request to the 3.14 branch. |
orsenthil
pushed a commit
to orsenthil/cpython
that referenced
this pull request
Nov 12, 2026
…ythonGH-161829) pythongh-161827: Mark _PyEval_EvalFrameDefault as Py_NO_INLINE Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #161827, with the tail-calling interpreter
_PyEval_EvalFrameDefaultcan get inlined into its callers (e.g. with Clang PGO) and no longer appear in the native call stack. This marks itPy_NO_INLINEso tools that rely on finding it keep working._PyEval_EvalFrameDefaultnot in the call stack when interpreter is built with--with-tail-call-interp#161827