Repository navigation
Conversation
Clang LTO with a GNU linker needs the LLVMgold.so plugin, which some distributions (e.g. Debian 13) don't ship. When using Clang with --with-lto on non-macOS platforms, configure now test-links an LTO program and, if that fails, retries with -fuse-ld=lld.
nascheme
marked this pull request as ready for review
November 11, 2026 21:56
nascheme
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
November 11, 2026 21:56
emmatyping
reviewed
Nov 11, 2026
emmatyping
left a comment
emmatyping
left a comment
Member
There was a problem hiding this comment.
A couple of minor nits/suggestions but otherwise looks good!
| than macOS, configure tries ``-fuse-ld=lld`` if the configured linker cannot | ||
| link a Clang LTO program. | ||
|
|
||
| .. versionchanged:: 3.16 |
Member
There was a problem hiding this comment.
Suggested change
| .. versionchanged:: 3.16 | |
| .. versionchanged:: next |
Comment on lines
+2226
to
+2227
| save_LDFLAGS="$LDFLAGS" | ||
| LDFLAGS="$LDFLAGS $LDFLAGS_NODIST $LTOFLAGS" |
Member
There was a problem hiding this comment.
I think it would be better to use the SAVE_ENV macro here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang LTO with a GNU linker needs the LLVMgold.so plugin, which some distributions (e.g. Debian 13) don't ship. When using Clang with --with-lto on non-macOS platforms, configure now test-links an LTO program and, if that fails, retries with -fuse-ld=lld.