Skip to content

gh-161808: Raise SyntaxError for unsupported ElementPath tokens #161810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qventymr wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

gh-161808: Raise SyntaxError for unsupported ElementPath tokens #161810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Lib/test/test_xml_etree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4064,6 +4064,19 @@ def test_bad_find(self):
with self.assertRaisesRegex(SyntaxError, 'cannot use absolute path'):
e.findall('/tag')

def test_find_invalid_path(self):
e = ET.XML(SAMPLE_XML)
paths = ('@', './x=y', './(', './)', './]', './!=', './::',
'./()', "./'tag'", './"tag"', 'tag/@')
for obj in (e, ET.ElementTree(e)):
for method in ('find', 'findall', 'findtext', 'iterfind'):
for path in paths:
with self.subTest(type=type(obj).__name__,
method=method, path=path):
self.assertRaisesRegex(
SyntaxError, '^invalid path$',
getattr(obj, method), path)

def test_find_through_ElementTree(self):
e = ET.XML(SAMPLE_XML)
self.assertEqual(ET.ElementTree(e).find('tag').tag, 'tag')
Expand Down
5 changes: 4 additions & 1 deletion Lib/xml/etree/ElementPath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,11 @@ def iterfind(elem, path, namespaces=None):
return
selector = []
while 1:
prepare = ops.get(token[0])
if prepare is None:
raise SyntaxError("invalid path") from None
try:
selector.append(ops[token[0]](next, token))
selector.append(prepare(next, token))
except StopIteration:
raise SyntaxError("invalid path") from None
try:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-11-11-14-29-41.gh-issue-161808.S9dK2p.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Raise :exc:`SyntaxError` instead of :exc:`KeyError` for unsupported XPath
tokens in :mod:`xml.etree.ElementTree` path searches.
Loading