Repository navigation
Conversation
…ike objects The Pickler file contract said write() accepts a single bytes argument, but with protocols 4 and 5 both picklers may pass bytearray, memoryview or PickleBuffer objects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
eachimei
force-pushed
the
gh-161803-pickle-write-bytes-like
branch
from
November 11, 2026 10:26
8dc3d5e to
bc120d7
Compare
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Picklerfile contract sayswrite()"accepts a single bytes argument". With protocols 4 and 5 that is inaccurate: both the C and the pure-Python picklers can passbytearray,memoryvieworPickleBufferobjects, and custom file objects that calllen(data)then fail. See gh-161803; gh-88605 is the same problem inbz2/lzma.This PR:
Doc/library/pickle.rst,Lib/pickle.pyand the twoModules/_pickle.cdocstrings, and regenerates the clinic output;memoryview(data).nbytesfor byte counts.Docs only; no behaviour change.