Skip to content

gh-161788: Handle path-like commands in shutil.which() #161789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Builder106 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

gh-161788: Handle path-like commands in shutil.which() #161789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ def which(cmd, mode=os.F_OK | os.X_OK, path=None):
path.

"""
cmd = os.fspath(cmd)
use_bytes = isinstance(cmd, bytes)

# If we're given a path with a directory part, look it up directly rather
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2614,6 +2614,10 @@ def test_basic(self):
rv = shutil.which(self.file, path=self.dir)
self.assertEqual(rv, self.filepath)

def test_pathlike_cmd(self):
rv = shutil.which(FakePath(self.file), path=self.dir)
self.assertEqual(rv, self.filepath)

def test_absolute_cmd(self):
# When given the fully qualified path to an executable that exists,
# it should be returned.
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-11-10-23-51-25.gh-issue-161788.J8vQmK.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :func:`shutil.which` for path-like command objects whose
:meth:`~os.PathLike.__fspath__` method returns :class:`bytes`.
Loading