Skip to content

gh-161769: Preserve errno across release thread-state attachment #161770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robolightning wants to merge 5 commits into
base: main
Choose a base branch
from
+20 −4
Open

gh-161769: Preserve errno across release thread-state attachment #161770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b9d037
Preserve errno across thread-state attachment in release builds
Robolightning Nov 10, 2026
452cc04
gh-161769: Document errno preservation across thread-state attachment
Robolightning Nov 10, 2026
87ad37c
gh-161769: Render errno as a literal in NEWS
Robolightning Nov 10, 2026
920a86d
gh-161769: Use standard long timeouts for concurrent regression
Robolightning Nov 10, 2026
aac344d
gh-161769: Focus errno regression on ordinary threads and GC
Robolightning Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Lib/test/test_free_threading/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,23 @@

@threading_helper.requires_working_threading()
class TestOs(unittest.TestCase):
def test_listdir_during_gc(self):
import gc
from pathlib import Path
import tempfile

with tempfile.TemporaryDirectory() as directory:
expected = {f"entry_{n}" for n in range(32)}
for name in expected:
Path(directory, name).touch()

def worker():
for _ in range(256):
gc.collect()
self.assertEqual(set(os.listdir(directory)), expected)

run_concurrently(worker, nthreads=4)

@unittest.skipUnless(sysconfig.get_config_var('_Py_HAVE_STRERROR_R'),
'need _Py_HAVE_STRERROR_R macro')
def test_strerror(self):
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-11-10-18-17-09.gh-issue-161769.wL6r9A.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Preserve ``errno`` across thread-state attachment in release builds,
preventing spurious directory I/O errors on free-threaded builds during
concurrent garbage collection.
4 changes: 0 additions & 4 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,11 +2383,9 @@ tstate_wait_attach(PyThreadState *tstate)
void
_PyThreadState_Attach(PyThreadState *tstate)
{
#if defined(Py_DEBUG)
// This is called from PyEval_RestoreThread(). Similar
// to it, we need to ensure errno doesn't change.
int err = errno;
#endif

_Py_EnsureTstateNotNULL(tstate);
if (current_fast_get() != NULL) {
Expand Down Expand Up @@ -2434,9 +2432,7 @@ _PyThreadState_Attach(PyThreadState *tstate)
_PyStats_Attach((_PyThreadStateImpl *)tstate);
#endif

#if defined(Py_DEBUG)
errno = err;
#endif
}

static void
Expand Down
Loading