Skip to content

[3.14] gh-158336: Fix race in lock_tests test_set_and_clear (GH-158337) #161683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Nov 9, 2026
Merged

[3.14] gh-158336: Fix race in lock_tests test_set_and_clear (GH-158337) #161683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Lib/test/lock_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,8 @@ def test_nan_timeout(self):
evt = self.eventtype()
self.assertRaises(ValueError, evt.wait, float('nan'))

# Use private attributes (event._cond._waiters)
@support.cpython_only
def test_set_and_clear(self):
# gh-57711: check that wait() returns true even when the event is
# cleared before the waiting thread is woken up.
Expand All @@ -571,8 +573,11 @@ def f():

N = 5
with Bunch(f, N):
# Threads blocked on event.wait()
wait_threads_blocked(N)
# Wait until all threads are registered as waiters in
# event.wait().
for _ in support.sleeping_retry(support.SHORT_TIMEOUT):
if len(event._cond._waiters) >= N:
break

# Threads unblocked
event.set()
Expand Down
Loading