bpo-38080 [2to3] Added getproxies to urllib fixes#16167
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This is my testing code # some_file.py
import urllib.getproxies
print "Hello world!"After running from urllib.request import getproxies
print("Hello world!")I also signed CLA document :) |
f3daaaa to
cb29251
Compare
|
Please add a NEWS entry : https://devguide.python.org/committing/?highlight=news#what-s-new-and-news-entries . The test looks good to me and the addition seems to be a simple fix too. Thanks. |
cb29251 to
54bc664
Compare
|
@tirkarthi I was not able to run I followed the instructions, and looked good, please correct me if I am wrong |
There was a problem hiding this comment.
Please also revert this whitespace change.
There was a problem hiding this comment.
| Added support to fix ``getproxies`` in the :mod:`lib2to3.fixes.fix_urllib`. | |
| module. Patch by José Roberto Meza Cabrera. | |
| Added support to fix ``getproxies`` in the :mod:`lib2to3.fixes.fix_urllib` | |
| module. Patch by José Roberto Meza Cabrera. |
There was a problem hiding this comment.
You are right, Done!
pablogsal
left a comment
There was a problem hiding this comment.
@robertpro There is an extra "." that should not be there.
Otherwise LGTM
|
Thanks @robertpro for the PR! Buen trabajo! 🎉 |
|
Congratulations @robertpro! |
|
@pablogsal @pascalin Gracias amigos! |
https://bugs.python.org/issue38080