Repository navigation
gh-161617: Fix test_clinic, test_tools, test_generated_cases with lazy imports - #161618
Conversation
…es` with lazy imports
| @@ -32,7 +32,7 @@ def skip_if_missing(tool=None): | |||
| @contextlib.contextmanager | |||
| def imports_under_tool(name, *subdirs): | |||
There was a problem hiding this comment.
Oh wait, does it not make sense to do it here instead?
There was a problem hiding this comment.
I don't think so, it might be required for other places that use DirsOnSysPath as well, since it is a broader API. We can alternatevly make a separate API called with forced_eager_imports(): and use it here. WDYT?
There was a problem hiding this comment.
Yeah, I think it is a better and more compsable API :)
|
I also need this new context manager in #161660 :) |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
Sorry, @sobolevn, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-161865 is a backport of this pull request to the 3.15 branch. |
Looks like that my change to
imports_under_toolalso fixed other tests.So, I removed them from the ignore as well.
test_clinicto pass withPYTHON_LAZY_IMPORTS=all#161617