bpo-38175: Fix a memory leak in comparison of sqlite3.Row objects.#16155
Merged
serhiy-storchaka merged 2 commits intoSep 16, 2019
Merged
Conversation
serhiy-storchaka
added
type-bug
berkerpeksag
left a comment
berkerpeksag
left a comment
Member
There was a problem hiding this comment.
LGTM, the new code looks much better, thank you very much! I only have two minor comments on the patch.
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8. |
|
GH-16193 is a backport of this pull request to the 3.8 branch. |
|
GH-16194 is a backport of this pull request to the 3.7 branch. |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 16, 2019
…ythonGH-16155) (cherry picked from commit 8debfa5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 17, 2019
…ts. (pythonGH-16155). (cherry picked from commit 8debfa5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-16215 is a backport of this pull request to the 2.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 17, 2019
miss-islington
added a commit
that referenced
this pull request
Sep 17, 2019
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 17, 2019
Member
Author
|
Thank you for your review @berkerpeksag! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38175