bpo-38135: Fix depth-first-search computation in compile.c#16042
Merged
Yhg1s merged 1 commit intopython:masterfrom Sep 12, 2019
Merged
bpo-38135: Fix depth-first-search computation in compile.c#16042Yhg1s merged 1 commit intopython:masterfrom
Yhg1s merged 1 commit intopython:masterfrom
Conversation
gpshead
reviewed
Sep 12, 2019
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
At a glance I believe this is correct. Looping Thomas in as a reviewer as I believe he's been working in the compile code recently.
Member
|
I won't say "recently" (I looked at peephole.c the last couple of days, but not compile.c), but I'm familiar enough. The new code does look a lot more sensible than reversing twice. |
gpshead
pushed a commit
that referenced
this pull request
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current compiler it is impossible to expose the bug in the block ordering computation.
Consequently, there is no observable change in behavior and thus no news item is necessary.
https://bugs.python.org/issue38135