Skip to content

bpo-36634: Fixes activate.bat when existing values contain double quotes#15924

Merged
zware merged 2 commits into
python:masterfrom
zooba:bpo-36634
Sep 11, 2019
Merged

bpo-36634: Fixes activate.bat when existing values contain double quotes#15924
zware merged 2 commits into
python:masterfrom
zooba:bpo-36634

Conversation

@zooba

@zooba zooba commented Sep 11, 2019

Copy link
Copy Markdown
Member

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware
zware merged commit 574b324 into python:master Sep 11, 2019
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@zooba
zooba deleted the bpo-36634 branch September 11, 2019 14:41
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
…tes (pythonGH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-15968 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-15969 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
…tes (pythonGH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Sep 11, 2019
…tes (GH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Sep 11, 2019
…tes (GH-15924)

(cherry picked from commit 574b324)

Co-authored-by: Steve Dower <steve.dower@python.org>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants