Skip to content

[3.8] bpo-35066: Make trailing percent test more portable. (GH-15907) #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Sep 11, 2019
Merged

[3.8] bpo-35066: Make trailing percent test more portable. (GH-15907) #15915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,15 +1449,20 @@ def test_strftime(self):
t.strftime("%f")

def test_strftime_trailing_percent(self):
# bpo-35066: make sure trailing '%' doesn't cause
# datetime's strftime to complain
# bpo-35066: Make sure trailing '%' doesn't cause datetime's strftime to
# complain. Different libcs have different handling of trailing
# percents, so we simply check datetime's strftime acts the same as
# time.strftime.
t = self.theclass(2005, 3, 2)
try:
_time.strftime('%')
except ValueError:
self.skipTest('time module does not support trailing %')
self.assertEqual(t.strftime('%'), '%')
self.assertEqual(t.strftime("m:%m d:%d y:%y %"), "m:03 d:02 y:05 %")
self.assertEqual(t.strftime('%'), _time.strftime('%', t.timetuple()))
self.assertEqual(
t.strftime("m:%m d:%d y:%y %"),
_time.strftime("m:03 d:02 y:05 %", t.timetuple()),
)

def test_format(self):
dt = self.theclass(2007, 9, 10)
Expand Down