Skip to content

gh-158529: Prevent mimalloc calling system calls directly on Android - #158530

Merged
mhsmith merged 3 commits into
python:mainfrom
mhsmith:android-mimalloc-syscall
Nov 9, 2026
Merged

gh-158529: Prevent mimalloc calling system calls directly on Android#158530
mhsmith merged 3 commits into
python:mainfrom
mhsmith:android-mimalloc-syscall

Conversation

@mhsmith

@mhsmith mhsmith commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@mhsmith mhsmith added OS-android needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 30, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 30, 2026
Closed
freakboy3742
freakboy3742 requested changes Sep 30, 2026
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself makes sense. However, mimalloc is vendored code; my understanding is that any changes we make here should be reflected (and accepted) as patches upstream as well, or else they'll get lost if/when mimalloc sources are bumped.

@bedevere-app

bedevere-app Bot commented Sep 30, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland

StanFromIreland commented Oct 1, 2026

Copy link
Copy Markdown
Member

However, mimalloc is vendored code; my understanding is that any changes we make here should be reflected (and accepted) as patches upstream as well, or else they'll get lost if/when mimalloc sources are bumped.

They're currently tracked at #113141, I presume a comment there should be fine.

daanx added a commit to microsoft/mimalloc that referenced this pull request Oct 8, 2026
@daanx
prevent syscalls on Android, upstream of python/cpython#158530 (and p…
aef8faa 
…ython/cpython#113141)
@mhsmith mhsmith mentioned this pull request Nov 9, 2026
Open
@mhsmith

mhsmith commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

Thanks to @daanx, this has now been merged and released upstream (microsoft/mimalloc@aef8faa). I've added it to the list in #113141 for future reference.

@mhsmith
mhsmith enabled auto-merge (squash) November 9, 2026 21:39
@mhsmith
mhsmith merged commit 78407da into python:main Nov 9, 2026
58 checks passed
@miss-islington-app

miss-islington-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

Thanks @mhsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

GH-161709 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 9, 2026
@bedevere-app

bedevere-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

GH-161710 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 9, 2026
mhsmith added a commit that referenced this pull request Nov 9, 2026
@miss-islington @mhsmith
[3.14] gh-158529: Prevent mimalloc calling system calls directly on A…
5810a10 
…ndroid (GH-158530) (#161710)

(cherry picked from commit 78407da)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
mhsmith added a commit that referenced this pull request Nov 9, 2026
@miss-islington @mhsmith
[3.15] gh-158529: Prevent mimalloc calling system calls directly on A…
04cfecc 
…ndroid (GH-158530) (#161709)

(cherry picked from commit 78407da)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
orsenthil pushed a commit to orsenthil/cpython that referenced this pull request Nov 12, 2026
@mhsmith @orsenthil
pythongh-158529: Prevent mimalloc calling system calls directly on An…
7889f11 
…droid (python#158530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 requested changes
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity

Assignees

No one assigned

Labels

OS-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mimalloc crashes on Android x86_64, API levels 27-28

3 participants

@mhsmith @StanFromIreland @freakboy3742