Conversation
ashm-dev
requested review from
Eclips4,
lysnikolaou,
pablogsal and
tomasr8
as code owners
September 11, 2026 08:56
Member
|
Thank you, but I said I would send the patch. This isn't the direction I discussed internally. I'd like the crash fix to land after #156022. |
Contributor
Author
|
Sorry about that, my bad — I missed the note in the issue description that you were already planning to send a patch. Happy to put this on hold until #156022 lands. If you'd like, I can rebase and adapt this PR to the direction you and @encukou discussed once #156022 is in. If you'd still prefer to submit your own patch instead, no problem at all, feel free to close this. |
Member
|
I don’t appreciate you copy-pasting LLM output to reply, please use your own words. Thank you for helping, I'll make the patch. |
Contributor
Author
|
Not an LLM, just basic courtesy. Closing so you can submit your patch. |
Member
|
Thanks @ashm-dev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ast.AST.__repr__can crash on missing_fields#156909