Fix idlelib.help comments#15669
Conversation
|
@taleinat I made minor changes to comment texts and will consider a few more. I think I found a mismatch between indent() and one of its calls. The comment asserts that self.indent(0) will set self.level to 0 and then self.tags to ''. But it leaves self.level alone and only resets self.tags if self.level was already 0. As it turns out, the latter is always true, as I would expect it to be if +1s and -1s are properly matched. So I think the call should be replaced with |
I noticed that too but didn't investigate. I suggest separating into three methods: |
taleinat
left a comment
There was a problem hiding this comment.
The comment changes look fine to me.
|
After more thought, I went with |
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-15683 is a backport of this pull request to the 3.8 branch. |
|
GH-15684 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 6cd9666) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 6cd9666) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 6cd9666) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 6cd9666) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Format comments as sentences and use sentences when possible.