bpo-37994: Fix silencing all errors if an attribute lookup fails.#15630
Merged
serhiy-storchaka merged 1 commit intoSep 1, 2019
Merged
Conversation
Only AttributeError should be silenced.
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 1, 2019
…s. (pythonGH-15630) Only AttributeError should be silenced.. (cherry picked from commit 41c57b3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-15635 is a backport of this pull request to the 3.8 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 1, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…thonGH-15630) Only AttributeError should be silenced.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…thonGH-15630) Only AttributeError should be silenced.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…thonGH-15630) Only AttributeError should be silenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only AttributeError should be silenced.
https://bugs.python.org/issue37994