gh-156026: document tar filter link targets - #156056
Open
Amandot wants to merge 1 commit into
Open
Conversation
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the behavior of the
tarextraction filter when handlingsymbolic-link targets.
tar_filterprotects against archive member paths escaping the extractiondestination, but it does not check
TarInfo.linkname. As a result, symboliclinks with absolute targets or relative targets outside the destination are
not rejected by this filter.
This change clarifies that behavior in the
tarfilter documentation andthe
tar_filtersection.The stricter
data_filterbehavior is also documented, including theexceptions raised for unsafe link targets.
No extraction behavior has been changed.
Testing
git diff --checkrequired dependency installation and the check was not completed.